[Firebase AI] Fix Google AI useLimitedUseAppCheckTokens config
#15423
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to the Firebase AI integration tests. The main fix correctly configures the googleAI_v1beta_appCheckLimitedUse test instance to use limited-use App Check tokens, which was the primary goal. Additionally, the code is refactored to use the try #require(...) pattern from the Swift Testing framework, simplifying nil-checking and making the tests more concise. The PR also enhances readability by improving test case naming for different configurations and clarifying a TODO comment. Overall, these are solid changes that improve the correctness and maintainability of the test suite.
# Conflicts: # FirebaseAI/Tests/TestApp/Tests/Integration/LiveSessionTests.swift
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the useLimitedUseAppCheckTokens configuration for Google AI integration tests and improves the codebase by simplifying nil-checking with #require and enhancing test case name formatting. The changes are clear and well-aligned with the PR's description. I've added one minor suggestion for consistency in string handling within the test setup.
FirebaseAI/Tests/TestApp/Tests/Integration/LiveSessionTests.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
Fixed the
googleAI_v1beta_appCheckLimitedUseInstanceConfigin the Firebase AI Logic integration tests.(copy)to signify that it was identical to the other.Simplified
nilchecking inLiveSessionsTestswithtry #require(...)instead ofguard let ... else { Issue.record(...) }pattern.Fixed
locationformatting in test case naming.googleAI_v1beta_appCheckLimitedUsenow showsGoogle AI (v1beta) - FAC Limited-Use#no-changelog